ryanreed
/
Skyblock
1
1
Fork 0
Code Issues 0 Pull Requests 0 Releases 12 Activity
Labels Milestones
New Pull Request

#19 Autosaves and Simplifying SaveLevelDataComponent

Merged
ryanreed merged 14 commits from autosaves into master 1 month ago
Conversation 2 Commits 14 Files Changed 16
ryanreed commented 1 month ago
Owner

Features

  • Add Autosave support
  • Simpiflified the configuration of SaveLevelDataComponent (only need to set the SaveGameSettingsResource now) by:
    • Move from save names to save name prepends (e.g. save_game_data.tres -> save_) within SaveGameSettingsResource
    • Move the default_icon_resource export out of SaveLevelDataComponent and to SaveGameSettingsResource
    • Move the ui_node export out of SaveLevelDataComponent and to SaveLoadUI
## Features * Add Autosave support * Simpiflified the configuration of `SaveLevelDataComponent` (only need to set the `SaveGameSettingsResource` now) by: * Move from save names to save name prepends (e.g. `save_game_data.tres` -> `save_`) within `SaveGameSettingsResource` * Move the `default_icon_resource` export out of `SaveLevelDataComponent` and to `SaveGameSettingsResource` * Move the `ui_node` export out of `SaveLevelDataComponent` and to `SaveLoadUI`
ryanreed added 4 commits 1 month ago
ryanreed added 1 commit 1 month ago
ryanreed added 1 commit 1 month ago
ryanreed commented 1 month ago
Poster
Owner

Current Known Issue: AutoSave date is suing modified date but they're all being modified about the same time, meaning the save time looks identical.

Maybe created save time should be stored within the resource rather than checking the file modified?

Current Known Issue: AutoSave date is suing modified date but they're all being modified about the same time, meaning the save time looks identical. Maybe created save time should be stored within the resource rather than checking the file modified?
ryanreed added 1 commit 1 month ago
ryanreed added 2 commits 1 month ago
ryanreed added 1 commit 1 month ago
ryanreed added 1 commit 1 month ago
ryanreed commented 1 month ago
Poster
Owner

This is mostly ready to go, although there is 1 issue I can't figure out.

The AutosaveNotification UI is pretty random about being visible on screen even when the visibility is true. Even weirder is initially, I could get it to show up by just adding print(visible) as if that was affecting the visibility. I don't really understand it and will need to investigate it further.

This is mostly ready to go, although there is 1 issue I can't figure out. The `AutosaveNotification` UI is pretty random about being visible on screen even when the visibility is `true`. Even weirder is initially, I could get it to show up by just adding `print(visible)` as if that was affecting the visibility. I don't really understand it and will need to investigate it further.
ryanreed added 1 commit 1 month ago
ryanreed added 2 commits 1 month ago
ryanreed changed title from WIP: Autosaves and Simplifying SaveLevelDataComponent to Autosaves and Simplifying SaveLevelDataComponent 1 month ago
ryanreed merged commit c1ca3a98cb into master 1 month ago
ryanreed deleted branch autosaves 1 month ago
The pull request has been merged as c1ca3a98cb.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'autosaves'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes